Commit 3b8d5735 authored Jun 26, 2018 by Jason Gerecke Committed by Jiri Kosina Jul 03, 2018

HID: wacom: Correct touch maximum XY of 2nd-gen Intuos

The touch sensors on the 2nd-gen Intuos tablets don't use a 4096x4096
sensor like other similar tablets (3rd-gen Bamboo, Intuos5, etc.).
The incorrect maximum XY values don't normally affect userspace since
touch input from these devices is typically relative rather than
absolute. It does, however, cause problems when absolute distances
need to be measured, e.g. for gesture recognition. Since the resolution
of the touch sensor on these devices is 10 units / mm (versus 100 for
the pen sensor), the proper maximum values can be calculated by simply
dividing by 10.

Fixes: b5fd2a3e ("Input: wacom - add support for three new Intuos devices")
Signed-off-by: Jason Gerecke <jason.gerecke@wacom.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

parent 717adfda

drivers/hid/wacom_wac.c

+8 −2

Original line number	Diff line number	Diff line
		@@ -3365,9 +3365,15 @@ void wacom_setup_device_quirks(struct wacom *wacom)
		if (features->type >= INTUOSHT && features->type <= BAMBOO_PT)
		features->device_type \|= WACOM_DEVICETYPE_PAD;

		if (features->type == INTUOSHT2) {
		features->x_max = features->x_max / 10;
		features->y_max = features->y_max / 10;
		}
		else {
		features->x_max = 4096;
		features->y_max = 4096;
		}
		}
		else if (features->pktlen == WACOM_PKGLEN_BBTOUCH) {
		features->device_type \|= WACOM_DEVICETYPE_PAD;
		}

Admin message