Commit 3b8b6d05 authored Oct 22, 2015 by Jarkko Nikula Committed by Mark Brown Oct 23, 2015

spi: pxa2xx: Convert unique ID string of ACPI device as unsigned integer

Andy noticed numeric unique device ID is unsigned integer so convert it
using kstrtouint(). Actually integer in ACPI 2.0 and later is 64 bits
litte-endian unsigned integer but quite certainly having so big value here
would mean something extra than just the SPI bus number so it won't hurt to
assume only lower 32 bits carry the bus number for now.

Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent d2c2f6a4

drivers/spi/spi-pxa2xx.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -1305,7 +1305,8 @@ pxa2xx_spi_acpi_get_pdata(struct platform_device *pdev)
		struct resource *res;
		const struct acpi_device_id *adev_id = NULL;
		const struct pci_device_id *pcidev_id = NULL;
		int devid, type;
		unsigned int devid;
		int type;

		adev = ACPI_COMPANION(&pdev->dev);
		if (!adev)
		@@ -1352,7 +1353,7 @@ pxa2xx_spi_acpi_get_pdata(struct platform_device *pdev)
		ssp->pdev = pdev;

		ssp->port_id = -1;
		if (adev->pnp.unique_id && !kstrtoint(adev->pnp.unique_id, 0, &devid))
		if (adev->pnp.unique_id && !kstrtouint(adev->pnp.unique_id, 0, &devid))
		ssp->port_id = devid;

		pdata->num_chipselect = 1;

Admin message