ceph: take reference on mds request r_unsafe_dir (3b663780) · Commits · 戴 / test

We put ourselves on an inode list for the parent directory of metadata operations so that an fsync on the directory will wait for metadata updates to commit to disk. We weren't holding a reference to that directory, however, and under certain workloads (fsstress in this case) the directory can go away. Signed-off-by:

Sage Weil <sage@newdream.net>

fs/ceph/mds_client.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -578,6 +578,7 @@ static void __register_request(struct ceph_mds_client *mdsc,
		if (dir) {
		struct ceph_inode_info *ci = ceph_inode(dir);

		ihold(dir);
		spin_lock(&ci->i_unsafe_lock);
		req->r_unsafe_dir = dir;
		list_add_tail(&req->r_unsafe_dir_item, &ci->i_unsafe_dirops);
		@@ -598,6 +599,9 @@ static void __unregister_request(struct ceph_mds_client *mdsc,
		spin_lock(&ci->i_unsafe_lock);
		list_del_init(&req->r_unsafe_dir_item);
		spin_unlock(&ci->i_unsafe_lock);

		iput(req->r_unsafe_dir);
		req->r_unsafe_dir = NULL;
		}

		ceph_mdsc_put_request(req);

Admin message