Commit 3b52beff authored by Andreas Gruenbacher's avatar Andreas Gruenbacher Committed by Philipp Reisner
Browse files

drbd: Turn drbd_printk() into a polymorphic macro 



This allows drbd_alert(), drbd_err(), drbd_warn(), and drbd_info() to work for
a resource, device, or connection so that we don't have to introduce three
separate sets of macros for that.

The drbd_printk() macro itself is pretty ugly, but that problem is limited to
one place in the code.  Using drbd_printk() on an object type which it doesn't
understand results in an undefined drbd_printk_with_wrong_object_type symbol.

Signed-off-by: default avatarAndreas Gruenbacher <agruen@linbit.com>
Signed-off-by: default avatarPhilipp Reisner <philipp.reisner@linbit.com>
parent d0180171

drivers/block/drbd/drbd_int.h

+43 −15
Original line number Diff line number Diff line
@@ -100,21 +100,49 @@ extern char usermode_helper[]; 
struct drbd_device;

struct drbd_connection;



#define drbd_printk(level, device, fmt, args...) \

	dev_printk(level, disk_to_dev(device->vdisk), fmt, ## args)



#define drbd_dbg(device, fmt, args...) \

	drbd_printk(KERN_DEBUG, device, fmt, ## args)

#define drbd_alert(device, fmt, args...) \

	drbd_printk(KERN_ALERT, device, fmt, ## args)

#define drbd_err(device, fmt, args...) \

	drbd_printk(KERN_ERR, device, fmt, ## args)

#define drbd_warn(device, fmt, args...) \

	drbd_printk(KERN_WARNING, device, fmt, ## args)

#define drbd_info(device, fmt, args...) \

	drbd_printk(KERN_INFO, device, fmt, ## args)

#define drbd_emerg(device, fmt, args...) \

	drbd_printk(KERN_EMERG, device, fmt, ## args)

#define __drbd_printk_device(level, device, fmt, args...) \

	dev_printk(level, disk_to_dev((device)->vdisk), fmt, ## args)

#define __drbd_printk_peer_device(level, peer_device, fmt, args...) \

	dev_printk(level, disk_to_dev((peer_device)->device->vdisk), fmt, ## args)

#define __drbd_printk_resource(level, resource, fmt, args...) \

	printk(level "drbd %s: " fmt, (resource)->name, ## args)

#define __drbd_printk_connection(level, connection, fmt, args...) \

	printk(level "drbd %s: " fmt, (connection)->resource->name, ## args)



void drbd_printk_with_wrong_object_type(void);



#define __drbd_printk_if_same_type(obj, type, func, level, fmt, args...) \

	(__builtin_types_compatible_p(typeof(obj), type) || \

	 __builtin_types_compatible_p(typeof(obj), const type)), \

	func(level, (const type)(obj), fmt, ## args)



#define drbd_printk(level, obj, fmt, args...) \

	__builtin_choose_expr( \

	  __drbd_printk_if_same_type(obj, struct drbd_device *, \

			     __drbd_printk_device, level, fmt, ## args), \

	  __builtin_choose_expr( \

	    __drbd_printk_if_same_type(obj, struct drbd_resource *, \

			       __drbd_printk_resource, level, fmt, ## args), \

	    __builtin_choose_expr( \

	      __drbd_printk_if_same_type(obj, struct drbd_connection *, \

				 __drbd_printk_connection, level, fmt, ## args), \

	      __builtin_choose_expr( \

		__drbd_printk_if_same_type(obj, struct drbd_peer_device *, \

				 __drbd_printk_peer_device, level, fmt, ## args), \

		drbd_printk_with_wrong_object_type()))))



#define drbd_dbg(obj, fmt, args...) \

	drbd_printk(KERN_DEBUG, obj, fmt, ## args)

#define drbd_alert(obj, fmt, args...) \

	drbd_printk(KERN_ALERT, obj, fmt, ## args)

#define drbd_err(obj, fmt, args...) \

	drbd_printk(KERN_ERR, obj, fmt, ## args)

#define drbd_warn(obj, fmt, args...) \

	drbd_printk(KERN_WARNING, obj, fmt, ## args)

#define drbd_info(obj, fmt, args...) \

	drbd_printk(KERN_INFO, obj, fmt, ## args)

#define drbd_emerg(obj, fmt, args...) \

	drbd_printk(KERN_EMERG, obj, fmt, ## args)



#define dynamic_drbd_dbg(device, fmt, args...) \

	dynamic_dev_dbg(disk_to_dev(device->vdisk), fmt, ## args)

CRA Git | Maintained and supported by SUSTech CRA and CCSE