Commit 3b4c362e authored Dec 02, 2020 by Krzysztof Kozlowski

soc: samsung: exynos-chipid: initialize later - with arch_initcall



The Exynos ChipID driver on Exynos SoCs has only informational
purpose - to expose the SoC device in sysfs.  No other drivers
depend on it so there is really no benefit of initializing it early.

Instead, initialize everything with arch_initcall which:
1. Allows to use dev_info() as the SoC bus is present (since
   core_initcall),
2. Could speed things up because of execution in a SMP environment
   (after bringing up secondary CPUs, unlike early_initcall),
3. Reduces the amount of work to be done early, when the kernel has to
   bring up critical devices.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20201202195955.128633-2-krzk@kernel.org

parent 7136d6a9

drivers/soc/samsung/exynos-chipid.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -99,8 +99,8 @@ static int __init exynos_chipid_early_init(void)
		goto err;
		}

		/* it is too early to use dev_info() here (soc_dev is NULL) */
		pr_info("soc soc0: Exynos: CPU[%s] PRO_ID[0x%x] REV[0x%x] Detected\n",
		dev_info(soc_device_to_device(soc_dev),
		"Exynos: CPU[%s] PRO_ID[0x%x] REV[0x%x] Detected\n",
		soc_dev_attr->soc_id, product_id, revision);

		return 0;
		@@ -111,4 +111,4 @@ err:
		return ret;
		}

		early_initcall(exynos_chipid_early_init);
		arch_initcall(exynos_chipid_early_init);

Admin message