i2c: tegra: Check errors for both positive and negative values (3b3b8e59) · Commits · 戴 / test

The driver's code is inconsistent in regards to the error values checking. The correct way should be to check both positive and negative values. This patch cleans up the error-checks in the code. Note that the pm_runtime_get_sync() could return positive value on success, hence only relevant parts of the code are changed by this patch. Reviewed-by:

Michał Mirosław <mirq-linux@rere.qmqm.pl> Reviewed-by:

Andy Shevchenko <andy.shevchenko@gmail.com> Tested-by:

Thierry Reding <treding@nvidia.com> Signed-off-by:

Dmitry Osipenko <digetx@gmail.com> Signed-off-by:

Wolfram Sang <wsa@kernel.org>

drivers/i2c/busses/i2c-tegra.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -982,7 +982,7 @@ static void tegra_i2c_config_fifo_trig(struct tegra_i2c_dev *i2c_dev,

		slv_config.device_fc = true;
		ret = dmaengine_slave_config(chan, &slv_config);
		if (ret < 0) {
		if (ret) {
		dev_err(i2c_dev->dev, "DMA slave config failed: %d\n",
		ret);
		dev_err(i2c_dev->dev, "falling back to PIO\n");
		@@ -1222,7 +1222,7 @@ static int tegra_i2c_xfer_msg(struct tegra_i2c_dev *i2c_dev,
		xfer_size,
		DMA_FROM_DEVICE);
		err = tegra_i2c_dma_submit(i2c_dev, xfer_size);
		if (err < 0) {
		if (err) {
		dev_err(i2c_dev->dev,
		"starting RX DMA failed, err %d\n",
		err);
		@@ -1248,7 +1248,7 @@ static int tegra_i2c_xfer_msg(struct tegra_i2c_dev *i2c_dev,
		xfer_size,
		DMA_TO_DEVICE);
		err = tegra_i2c_dma_submit(i2c_dev, xfer_size);
		if (err < 0) {
		if (err) {
		dev_err(i2c_dev->dev,
		"starting TX DMA failed, err %d\n",
		err);

Admin message