Commit 3b364c65 authored Mar 23, 2020 by Chris Packham Committed by Bjorn Helgaas Mar 28, 2020

PCI/ASPM: Reduce severity of common clock config message

When the UEFI/BIOS or bootloader has not initialised a PCIe device we would
get the following message:

kern.warning: pci 0000:00:01.0: ASPM: current common clock configuration is broken, reconfiguring

"warning" and "broken" are slightly misleading. On an embedded system it is
quite possible for the bootloader to avoid configuring PCIe devices if they
are not needed.

Downgrade the message to pci_info() and change "broken" to "inconsistent"
since we fix up the inconsistency in the code immediately following the
message (and emit an error if that fails).

Link: https://lore.kernel.org/r/20200323035530.11569-1-chris.packham@alliedtelesis.co.nz

Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>

parent 58a3862a

drivers/pci/pcie/aspm.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -273,7 +273,7 @@ static void pcie_aspm_configure_common_clock(struct pcie_link_state *link)
		}
		if (consistent)
		return;
		pci_warn(parent, "ASPM: current common clock configuration is broken, reconfiguring\n");
		pci_info(parent, "ASPM: current common clock configuration is inconsistent, reconfiguring\n");
		}

		/* Configure downstream component, all functions */

Admin message