Commit 3b185255 authored Jul 07, 2020 by Zhihao Cheng Committed by Richard Weinberger Aug 02, 2020

ubi: fastmap: Don't produce the initial next anchor PEB when fastmap is disabled



Following process triggers a memleak caused by forgetting to release the
initial next anchor PEB (CONFIG_MTD_UBI_FASTMAP is disabled):
1. attach -> __erase_worker -> produce the initial next anchor PEB
2. detach -> ubi_fastmap_close (Do nothing, it should have released the
   initial next anchor PEB)

Don't produce the initial next anchor PEB in __erase_worker() when fastmap
is disabled.

Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
Suggested-by: Sascha Hauer <s.hauer@pengutronix.de>
Fixes: f9c34bb5 ("ubi: Fix producing anchor PEBs")
Reported-by:  <syzbot+d9aab50b1154e3d163f5@syzkaller.appspotmail.com>
Signed-off-by: Richard Weinberger <richard@nod.at>

parent fcf44196

drivers/mtd/ubi/wl.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -1086,7 +1086,8 @@ static int __erase_worker(struct ubi_device ubi, struct ubi_work wl_wrk)
		if (!err) {
		spin_lock(&ubi->wl_lock);

		if (!ubi->fm_next_anchor && e->pnum < UBI_FM_MAX_START) {
		if (!ubi->fm_disabled && !ubi->fm_next_anchor &&
		e->pnum < UBI_FM_MAX_START) {
		/* Abort anchor production, if needed it will be
		* enabled again in the wear leveling started below.
		*/

Admin message