Commit 3b034b0d authored by Vivek Goyal's avatar Vivek Goyal Committed by Tejun Heo
Browse files

percpu: Fix kdump failure if booted with percpu_alloc=page 



o kdump functionality reserves a per cpu area at boot time and exports the
  physical address of that area to user space through sys interface. This
  area stores some dump related information like cpu register states etc
  at the time of crash.

o We were assuming that per cpu area always come from linearly mapped meory
  region and using __pa() to determine physical address.
  With percpu_alloc=page, per cpu area can come from vmalloc region also and
  __pa() breaks.

o This patch implments a new function to convert per cpu address to
  physical address.

Before the patch, crash_notes addresses looked as follows.

cpu0 60fffff49800
cpu1 60fffff60800
cpu2 60fffff77800

These are bogus phsyical addresses.

After the patch, address are following.

cpu0 13eb44000
cpu1 13eb43000
cpu2 13eb42000
cpu3 13eb41000

These look fine. I got 4G of memory and /proc/iomem tell me following.

100000000-13fffffff : System RAM

tj: * added missing asm/io.h include reported by Stephen Rothwell
    * repositioned per_cpu_ptr_phys() in percpu.c and added comment.

Signed-off-by: default avatarVivek Goyal <vgoyal@redhat.com>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
parent 833af842

drivers/base/cpu.c

+1 −1
Original line number Diff line number Diff line
@@ -97,7 +97,7 @@ static ssize_t show_crash_notes(struct sys_device *dev, struct sysdev_attribute 
	 * boot up and this data does not change there after. Hence this

	 * operation should be safe. No locking required.

	 */

	addr = __pa(per_cpu_ptr(crash_notes, cpunum));

	addr = per_cpu_ptr_to_phys(per_cpu_ptr(crash_notes, cpunum));

	rc = sprintf(buf, "%Lx\n", addr);

	return rc;

}

include/linux/percpu.h

+1 −0
Original line number Diff line number Diff line
@@ -154,6 +154,7 @@ struct percpu_data { 


extern void *__alloc_percpu(size_t size, size_t align);

extern void free_percpu(void *__pdata);

extern phys_addr_t per_cpu_ptr_to_phys(void *addr);



#ifndef CONFIG_HAVE_SETUP_PER_CPU_AREA

extern void __init setup_per_cpu_areas(void);

mm/percpu.c

+22 −0
Original line number Diff line number Diff line
@@ -74,6 +74,7 @@ 
#include <asm/cacheflush.h>

#include <asm/sections.h>

#include <asm/tlbflush.h>

#include <asm/io.h>



#define PCPU_SLOT_BASE_SHIFT		5	/* 1-31 shares the same slot */

#define PCPU_DFL_MAP_ALLOC		16	/* start a map with 16 ents */
@@ -1302,6 +1303,27 @@ void free_percpu(void *ptr) 
}

EXPORT_SYMBOL_GPL(free_percpu);



/**

 * per_cpu_ptr_to_phys - convert translated percpu address to physical address

 * @addr: the address to be converted to physical address

 *

 * Given @addr which is dereferenceable address obtained via one of

 * percpu access macros, this function translates it into its physical

 * address.  The caller is responsible for ensuring @addr stays valid

 * until this function finishes.

 *

 * RETURNS:

 * The physical address for @addr.

 */

phys_addr_t per_cpu_ptr_to_phys(void *addr)

{

	if ((unsigned long)addr < VMALLOC_START ||

			(unsigned long)addr >= VMALLOC_END)

		return __pa(addr);

	else

		return page_to_phys(vmalloc_to_page(addr));

}



static inline size_t pcpu_calc_fc_sizes(size_t static_size,

					size_t reserved_size,

					ssize_t *dyn_sizep)

CRA Git | Maintained and supported by SUSTech CRA and CCSE