Commit 3ae30f4c authored Nov 16, 2016 by Johan Hovold Committed by David S. Miller Nov 17, 2016

of_mdio: fix device reference leak in of_phy_find_device



Make sure to drop the reference taken by bus_find_device() before
returning NULL from of_phy_find_device() when the found device is not a
PHY.

Fixes: 6ed74236 ("of: of_mdio: Ensure mdio device is a PHY")
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 48c1699d

drivers/of/of_mdio.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -292,6 +292,7 @@ struct phy_device of_phy_find_device(struct device_node phy_np)
		mdiodev = to_mdio_device(d);
		if (mdiodev->flags & MDIO_DEVICE_FLAG_PHY)
		return to_phy_device(d);
		put_device(d);
		}

		return NULL;

Admin message