Commit 3adfb572 authored Jan 27, 2017 by Christophe JAILLET Committed by Bjorn Helgaas Feb 10, 2017

PCI/MSI: Return failure when msix_setup_entries() fails



If alloc_msi_entry() fails, we free resources and set ret = -ENOMEM.

However, msix_setup_entries() returns 0 unconditionally.  Return the error
code instead.

Fixes: e75eafb9 ("genirq/msi: Switch to new irq spreading infrastructure")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>

parent 4fe03955

drivers/pci/msi.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -731,7 +731,7 @@ static int msix_setup_entries(struct pci_dev dev, void __iomem base,
		ret = 0;
		out:
		kfree(masks);
		return 0;
		return ret;
		}

		static void msix_program_entries(struct pci_dev *dev,

Admin message