ASoC: twl6040: Lower the power on gain values at startup (3acef685) · Commits · 戴 / test

The default gains on outputs/inputs are set to 0dB. This is fixing the pop noise issue at the first playback, which caused by the wrong starting point of the ramp code. The ramp code for the outputs expects the gains to be in their lowest configuration in order to be effective. After the playback stops, the ramp code takes care of ramping down the gains to their minimum. Signed-off-by:

Peter Ujfalusi <peter.ujfalusi@ti.com> Acked-by:

Liam Girdwood <lrg@ti.com> Signed-off-by:

Mark Brown <broonie@opensource.wolfsonmicro.com>

sound/soc/codecs/twl6040.c

+11 −0

Original line number	Diff line number	Diff line
		@@ -269,6 +269,17 @@ static void twl6040_init_chip(struct snd_soc_codec *codec)
		/* No imput selected for microphone amplifiers */
		twl6040_write_reg_cache(codec, TWL6040_REG_MICLCTL, 0x18);
		twl6040_write_reg_cache(codec, TWL6040_REG_MICRCTL, 0x18);

		/*
		* We need to lower the default gain values, so the ramp code
		* can work correctly for the first playback.
		* This reduces the pop noise heard at the first playback.
		*/
		twl6040_write_reg_cache(codec, TWL6040_REG_HSGAIN, 0xff);
		twl6040_write_reg_cache(codec, TWL6040_REG_EARCTL, 0x1e);
		twl6040_write_reg_cache(codec, TWL6040_REG_HFLGAIN, 0x1d);
		twl6040_write_reg_cache(codec, TWL6040_REG_HFRGAIN, 0x1d);
		twl6040_write_reg_cache(codec, TWL6040_REG_LINEGAIN, 0);
		}

		static void twl6040_restore_regs(struct snd_soc_codec *codec)

Admin message