Commit 3ab36ab6 authored Jul 31, 2008 by Eugeniy Meshcheryakov Committed by Linus Torvalds Aug 01, 2008

try harder to load tty ldisc driver



Currently function tty_ldisc_get() tries to load an ldisc driver module
only when tty_ldisc_try_get() returns -EAGAIN. This happens only if
module is being unloaded. If ldisc module is not loaded
tty_ldisc_try_get() returns -EINVAL and this case is not handled in
tty_ldisc_get(), so request_module() is not called.

Attached patch fixes this by calling request_module() if
tty_ldisc_try_get() returned any error code.

I discovered this when my UMTS modem stopped working with 2.6.27-rc1
because module ppp_async was not loaded.

Signed-off-by: Eugeniy Meshcheryakov <eugen@debian.org>
Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 84ff7a00

drivers/char/tty_ldisc.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -169,7 +169,7 @@ static int tty_ldisc_get(int disc, struct tty_ldisc *ld)
		if (disc < N_TTY \|\| disc >= NR_LDISCS)
		return -EINVAL;
		err = tty_ldisc_try_get(disc, ld);
		if (err == -EAGAIN) {
		if (err < 0) {
		request_module("tty-ldisc-%d", disc);
		err = tty_ldisc_try_get(disc, ld);
		}

Admin message