Commit 3ab21379 authored May 23, 2017 by Xin Long Committed by David S. Miller May 24, 2017

sctp: fix stream update when processing dupcookie



Since commit 3dbcc105 ("sctp: alloc stream info when initializing
asoc"), stream and stream.out info are always alloced when creating
an asoc.

So it's not correct to check !asoc->stream before updating stream
info when processing dupcookie, but would be better to check asoc
state instead.

Fixes: 3dbcc105 ("sctp: alloc stream info when initializing asoc")
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Acked-by: Vlad Yasevich <vyasevich@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 12e8b570

net/sctp/associola.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -1176,7 +1176,9 @@ void sctp_assoc_update(struct sctp_association *asoc,

		asoc->ctsn_ack_point = asoc->next_tsn - 1;
		asoc->adv_peer_ack_point = asoc->ctsn_ack_point;
		if (!asoc->stream) {

		if (sctp_state(asoc, COOKIE_WAIT)) {
		sctp_stream_free(asoc->stream);
		asoc->stream = new->stream;
		new->stream = NULL;
		}

Admin message