Commit 3a9d993e authored by Alex Deucher's avatar Alex Deucher
Browse files

drm/amdgpu/dce11: disable hpd on local panels 

Otherwise we can get a hotplug interrupt storm when
we turn the panel off if hpd interrupts were enabled
by the bios.

bug:
https://bugs.freedesktop.org/show_bug.cgi?id=97471



Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
parent e96ec90f

drivers/gpu/drm/amd/amdgpu/dce_v11_0.c

+13 −10
Original line number Diff line number Diff line
@@ -443,16 +443,6 @@ static void dce_v11_0_hpd_init(struct amdgpu_device *adev) 
	list_for_each_entry(connector, &dev->mode_config.connector_list, head) {

		struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);



		if (connector->connector_type == DRM_MODE_CONNECTOR_eDP ||

		    connector->connector_type == DRM_MODE_CONNECTOR_LVDS) {

			/* don't try to enable hpd on eDP or LVDS avoid breaking the

			 * aux dp channel on imac and help (but not completely fix)

			 * https://bugzilla.redhat.com/show_bug.cgi?id=726143

			 * also avoid interrupt storms during dpms.

			 */

			continue;

		}



		switch (amdgpu_connector->hpd.hpd) {

		case AMDGPU_HPD_1:

			idx = 0;
@@ -476,6 +466,19 @@ static void dce_v11_0_hpd_init(struct amdgpu_device *adev) 
			continue;

		}



		if (connector->connector_type == DRM_MODE_CONNECTOR_eDP ||

		    connector->connector_type == DRM_MODE_CONNECTOR_LVDS) {

			/* don't try to enable hpd on eDP or LVDS avoid breaking the

			 * aux dp channel on imac and help (but not completely fix)

			 * https://bugzilla.redhat.com/show_bug.cgi?id=726143

			 * also avoid interrupt storms during dpms.

			 */

			tmp = RREG32(mmDC_HPD_INT_CONTROL + hpd_offsets[idx]);

			tmp = REG_SET_FIELD(tmp, DC_HPD_INT_CONTROL, DC_HPD_INT_EN, 0);

			WREG32(mmDC_HPD_INT_CONTROL + hpd_offsets[idx], tmp);

			continue;

		}



		tmp = RREG32(mmDC_HPD_CONTROL + hpd_offsets[idx]);

		tmp = REG_SET_FIELD(tmp, DC_HPD_CONTROL, DC_HPD_EN, 1);

		WREG32(mmDC_HPD_CONTROL + hpd_offsets[idx], tmp);

CRA Git | Maintained and supported by SUSTech CRA and CCSE