drivers: Remove BKL from scx200_gpio (3a8183a2) · Commits · 戴 / test

cycle_kernel_lock() was added during the big BKL pushdown. It should ensure the serializiation against driver init code. In this case there is nothing to serialize. Remove it. Signed-off-by:

Thomas Gleixner <tglx@linutronix.de> LKML-Reference: <20091010153350.167321547@linutronix.de> Acked-by:

Jim Cromie <jim.cromie@gmail.com>

drivers/char/scx200_gpio.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -12,7 +12,6 @@
		#include <linux/kernel.h>
		#include <linux/init.h>
		#include <linux/platform_device.h>
		#include <linux/smp_lock.h>
		#include <asm/uaccess.h>
		#include <asm/io.h>

		@@ -52,7 +51,6 @@ static int scx200_gpio_open(struct inode inode, struct file file)
		unsigned m = iminor(inode);
		file->private_data = &scx200_gpio_ops;

		cycle_kernel_lock();
		if (m >= MAX_PINS)
		return -EINVAL;
		return nonseekable_open(inode, file);

Admin message