Commit 3a658e09 authored by Yangtao Li's avatar Yangtao Li Committed by Sebastian Reichel
Browse files

HSI: omap_ssi: Change to use DEFINE_SHOW_ATTRIBUTE macro 



Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.

Signed-off-by: default avatarYangtao Li <tiny.windzz@gmail.com>
Signed-off-by: default avatarSebastian Reichel <sebastian.reichel@collabora.com>
parent 65102238

drivers/hsi/controllers/omap_ssi_core.c

+4 −25
Original line number Diff line number Diff line
@@ -48,7 +48,7 @@ 
static DEFINE_IDA(platform_omap_ssi_ida);



#ifdef CONFIG_DEBUG_FS

static int ssi_debug_show(struct seq_file *m, void *p __maybe_unused)

static int ssi_regs_show(struct seq_file *m, void *p __maybe_unused)

{

	struct hsi_controller *ssi = m->private;

	struct omap_ssi_controller *omap_ssi = hsi_controller_drvdata(ssi);
@@ -63,7 +63,7 @@ static int ssi_debug_show(struct seq_file *m, void *p __maybe_unused) 
	return 0;

}



static int ssi_debug_gdd_show(struct seq_file *m, void *p __maybe_unused)

static int ssi_gdd_regs_show(struct seq_file *m, void *p __maybe_unused)

{

	struct hsi_controller *ssi = m->private;

	struct omap_ssi_controller *omap_ssi = hsi_controller_drvdata(ssi);
@@ -117,29 +117,8 @@ static int ssi_debug_gdd_show(struct seq_file *m, void *p __maybe_unused) 
	return 0;

}



static int ssi_regs_open(struct inode *inode, struct file *file)

{

	return single_open(file, ssi_debug_show, inode->i_private);

}



static int ssi_gdd_regs_open(struct inode *inode, struct file *file)

{

	return single_open(file, ssi_debug_gdd_show, inode->i_private);

}



static const struct file_operations ssi_regs_fops = {

	.open		= ssi_regs_open,

	.read		= seq_read,

	.llseek		= seq_lseek,

	.release	= single_release,

};



static const struct file_operations ssi_gdd_regs_fops = {

	.open		= ssi_gdd_regs_open,

	.read		= seq_read,

	.llseek		= seq_lseek,

	.release	= single_release,

};

DEFINE_SHOW_ATTRIBUTE(ssi_regs);

DEFINE_SHOW_ATTRIBUTE(ssi_gdd_regs);



static int ssi_debug_add_ctrl(struct hsi_controller *ssi)

{

drivers/hsi/controllers/omap_ssi_port.c

+2 −12
Original line number Diff line number Diff line
@@ -57,7 +57,7 @@ static void ssi_debug_remove_port(struct hsi_port *port) 
	debugfs_remove_recursive(omap_port->dir);

}



static int ssi_debug_port_show(struct seq_file *m, void *p __maybe_unused)

static int ssi_port_regs_show(struct seq_file *m, void *p __maybe_unused)

{

	struct hsi_port *port = m->private;

	struct omap_ssi_port *omap_port = hsi_port_drvdata(port);
@@ -132,17 +132,7 @@ static int ssi_debug_port_show(struct seq_file *m, void *p __maybe_unused) 
	return 0;

}



static int ssi_port_regs_open(struct inode *inode, struct file *file)

{

	return single_open(file, ssi_debug_port_show, inode->i_private);

}



static const struct file_operations ssi_port_regs_fops = {

	.open		= ssi_port_regs_open,

	.read		= seq_read,

	.llseek		= seq_lseek,

	.release	= single_release,

};

DEFINE_SHOW_ATTRIBUTE(ssi_port_regs);



static int ssi_div_get(void *data, u64 *val)

{

CRA Git | Maintained and supported by SUSTech CRA and CCSE