Commit 3a5ee3b3 authored by Fuqian Huang's avatar Fuqian Huang Committed by David S. Miller
Browse files

ethernet: remove redundant memset 



kvzalloc already zeroes the memory during the allocation.
pci_alloc_consistent calls dma_alloc_coherent directly.
In commit 518a2f19
("dma-mapping: zero memory returned from dma_alloc_*"),
dma_alloc_coherent has already zeroed the memory.
So the memset after these function is not needed.

Signed-off-by: default avatarFuqian Huang <huangfq.daxian@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent cef86f15

drivers/net/ethernet/atheros/atlx/atl1.c

+0 −2
Original line number Diff line number Diff line
@@ -1060,8 +1060,6 @@ static s32 atl1_setup_ring_resources(struct atl1_adapter *adapter) 
		goto err_nomem;

	}



	memset(ring_header->desc, 0, ring_header->size);



	/* init TPD ring */

	tpd_ring->dma = ring_header->dma;

	offset = (tpd_ring->dma & 0x7) ? (8 - (ring_header->dma & 0x7)) : 0;

drivers/net/ethernet/atheros/atlx/atl2.c

+0 −1
Original line number Diff line number Diff line
@@ -291,7 +291,6 @@ static s32 atl2_setup_ring_resources(struct atl2_adapter *adapter) 
		&adapter->ring_dma);

	if (!adapter->ring_vir_addr)

		return -ENOMEM;

	memset(adapter->ring_vir_addr, 0, adapter->ring_size);



	/* Init TXD Ring */

	adapter->txd_dma = adapter->ring_dma ;

drivers/net/ethernet/broadcom/bnxt/bnxt.c

+0 −2
Original line number Diff line number Diff line
@@ -2677,8 +2677,6 @@ static int bnxt_alloc_tx_rings(struct bnxt *bp) 
			mapping = txr->tx_push_mapping +

				sizeof(struct tx_push_bd);

			txr->data_mapping = cpu_to_le64(mapping);



			memset(txr->tx_push, 0, sizeof(struct tx_push_bd));

		}

		qidx = bp->tc_to_qidx[j];

		ring->queue_id = bp->q_info[qidx].queue_id;

drivers/net/ethernet/chelsio/cxgb4/sched.c

+0 −1
Original line number Diff line number Diff line
@@ -207,7 +207,6 @@ static int t4_sched_queue_bind(struct port_info *pi, struct ch_sched_queue *p) 
		goto out_err;



	/* Bind queue to specified class */

	memset(qe, 0, sizeof(*qe));

	qe->cntxt_id = qid;

	memcpy(&qe->param, p, sizeof(qe->param));

drivers/net/ethernet/freescale/fec_main.c

+0 −2
Original line number Diff line number Diff line
@@ -3144,8 +3144,6 @@ static int fec_enet_init(struct net_device *ndev) 
		return -ENOMEM;

	}



	memset(cbd_base, 0, bd_size);



	/* Get the Ethernet address */

	fec_get_mac(ndev);

	/* make sure MAC we just acquired is programmed into the hw */

CRA Git | Maintained and supported by SUSTech CRA and CCSE