Commit 3a43e69c authored Jan 08, 2008 by FUJITA Tomonori Committed by James Bottomley Jan 09, 2008

[SCSI] qla1280: fix 32 bit segment code

There's an error remaining in the 32 bit descriptor code after the
conversion to dma accessors: req_cnt is left uninitialised.

qla1280_32bit_start_scsi gives the following warnings:

drivers/scsi/qla1280.c: In function 'qla1280_32bit_start_scsi':
drivers/scsi/qla1280.c:3044: warning: unused variable 'dma_handle'
drivers/scsi/qla1280.c: In function 'qla1280_queuecommand':
drivers/scsi/qla1280.c:3060: warning: 'req_cnt' is used uninitialized in this function
drivers/scsi/qla1280.c:3042: note: 'req_cnt' was declared here

Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>

parent fd0b45df

drivers/scsi/qla1280.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -3041,7 +3041,6 @@ qla1280_32bit_start_scsi(struct scsi_qla_host ha, struct srb sp)
		int cnt;
		int req_cnt;
		int seg_cnt;
		dma_addr_t dma_handle;
		u8 dir;

		ENTER("qla1280_32bit_start_scsi");
		@@ -3050,6 +3049,7 @@ qla1280_32bit_start_scsi(struct scsi_qla_host ha, struct srb sp)
		cmd->cmnd[0]);

		/* Calculate number of entries and segments required. */
		req_cnt = 1;
		seg_cnt = scsi_dma_map(cmd);
		if (seg_cnt) {
		/*

Admin message