Commit 3a22ebe9 authored Jan 29, 2011 by Stefan Achatz Committed by Jiri Kosina Feb 01, 2011

HID: hidraw: fix hidraw_disconnect()



hidraw_disconnect() first sets an entry in hidraw_table to NULL
and calls device_destroy() afterwards. The thereby called
hidraw_release() tries to read this already cleared value resulting
in never removing any device from the list.
This got fixed by changing the order of events.

Signed-off-by: Stefan Achatz <erazor_de@users.sourceforge.net>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

parent 581548db

drivers/hid/hidraw.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -428,12 +428,12 @@ void hidraw_disconnect(struct hid_device *hid)

		hidraw->exist = 0;

		device_destroy(hidraw_class, MKDEV(hidraw_major, hidraw->minor));

		mutex_lock(&minors_lock);
		hidraw_table[hidraw->minor] = NULL;
		mutex_unlock(&minors_lock);

		device_destroy(hidraw_class, MKDEV(hidraw_major, hidraw->minor));

		if (hidraw->open) {
		hid_hw_close(hid);
		wake_up_interruptible(&hidraw->wait);

Admin message