Commit 3a21409a authored by David Howells's avatar David Howells Committed by Anna Schumaker
Browse files

nfs: Return EINVAL rather than ERANGE for mount parse errors 



Return EINVAL rather than ERANGE for mount parse errors as the userspace
mount command doesn't necessarily understand what to do with anything other
than EINVAL.

The old code returned -ERANGE as an intermediate error that then get
converted to -EINVAL, whereas the new code returns -ERANGE.

This was induced by passing minorversion=1 to a v4 mount where
CONFIG_NFS_V4_1 was disabled in the kernel build.

Fixes: 68f65ef40e1e ("NFS: Convert mount option parsing to use functionality from fs_parser.h")
Reported-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
Signed-off-by: default avatarAnna Schumaker <Anna.Schumaker@Netapp.com>
parent b24ee6c6

fs/nfs/fs_context.c

+1 −2
Original line number Diff line number Diff line
@@ -779,8 +779,7 @@ out_invalid_value: 
out_invalid_address:

	return nfs_invalf(fc, "NFS: Bad IP address specified");

out_of_bounds:

	nfs_invalf(fc, "NFS: Value for '%s' out of range", param->key);

	return -ERANGE;

	return nfs_invalf(fc, "NFS: Value for '%s' out of range", param->key);

}



/*

CRA Git | Maintained and supported by SUSTech CRA and CCSE