Commit 3a13813e authored by Stephen Hemminger's avatar Stephen Hemminger Committed by David S. Miller
Browse files

[BRIDGE] netfilter: memory corruption fix 



The bridge-netfilter code will overwrite memory if there is not
headroom in the skb to save the header.  This first showed up when
using Xen with sky2 driver that doesn't allocate the extra space.

Signed-off-by: default avatarStephen Hemminger <shemminger@osdl.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 8dbc1603

include/linux/netfilter_bridge.h

+12 −2
Original line number Diff line number Diff line
@@ -48,16 +48,26 @@ enum nf_br_hook_priorities { 


/* Only used in br_forward.c */

static inline

void nf_bridge_maybe_copy_header(struct sk_buff *skb)

int nf_bridge_maybe_copy_header(struct sk_buff *skb)

{

	int err;



	if (skb->nf_bridge) {

		if (skb->protocol == __constant_htons(ETH_P_8021Q)) {

			err = skb_cow(skb, 18);

			if (err)

				return err;

			memcpy(skb->data - 18, skb->nf_bridge->data, 18);

			skb_push(skb, 4);

		} else

		} else {

			err = skb_cow(skb, 16);

			if (err)

				return err;

			memcpy(skb->data - 16, skb->nf_bridge->data, 16);

		}

	}

	return 0;

}



/* This is called by the IP fragmenting code and it ensures there is

 * enough room for the encapsulating header (if there is one). */

net/bridge/br_forward.c

+7 −3
Original line number Diff line number Diff line
@@ -40,12 +40,16 @@ int br_dev_queue_push_xmit(struct sk_buff *skb) 
	else {

#ifdef CONFIG_BRIDGE_NETFILTER

		/* ip_refrag calls ip_fragment, doesn't copy the MAC header. */

		nf_bridge_maybe_copy_header(skb);

		if (nf_bridge_maybe_copy_header(skb))

			kfree_skb(skb);

		else

#endif

		{

			skb_push(skb, ETH_HLEN);



			dev_queue_xmit(skb);

		}

	}



	return 0;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE