atl1: Do not wake queue before queue has been started. (39d48157) · Commits · 戴 / test

Based upon a bug report by Alexey Dobriyan, the patch is also tested by him and confirmed to fix the problem. Packet flow during link state events should not be done by waking and stopping the TX queue anyways, that is handled transparently by netif_carrier_{on,off}(). So, remove the netif_{wake,stop}_queue() calls in the link check code, and add the necessary netif_start_queue() call to atl1_up(). Signed-off-by:

David S. Miller <davem@davemloft.net>

drivers/net/atlx/atl1.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -1308,7 +1308,6 @@ static u32 atl1_check_link(struct atl1_adapter *adapter)
		dev_info(&adapter->pdev->dev, "link is down\n");
		adapter->link_speed = SPEED_0;
		netif_carrier_off(netdev);
		netif_stop_queue(netdev);
		}
		return 0;
		}
		@@ -1358,7 +1357,6 @@ static u32 atl1_check_link(struct atl1_adapter *adapter)
		if (!netif_carrier_ok(netdev)) {
		/* Link down -> Up */
		netif_carrier_on(netdev);
		netif_wake_queue(netdev);
		}
		return 0;
		}
		@@ -2627,6 +2625,7 @@ static s32 atl1_up(struct atl1_adapter *adapter)
		mod_timer(&adapter->watchdog_timer, jiffies);
		atlx_irq_enable(adapter);
		atl1_check_link(adapter);
		netif_start_queue(netdev);
		return 0;

		err_up:

Admin message