Commit 39cc98f1 authored May 26, 2011 by Michal Hocko Committed by Linus Torvalds May 26, 2011

memcg: remove pointless next_mz nullification in mem_cgroup_soft_limit_reclaim()



next_mz is assigned to NULL if __mem_cgroup_largest_soft_limit_node
selects the same mz.  This doesn't make much sense as we assign to the
variable right in the next loop.

Compiler will probably optimize this out but it is little bit confusing
for the code reading.

Signed-off-by: Michal Hocko <mhocko@suse.cz>
Acked-by: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
Cc: Balbir Singh <balbir@linux.vnet.ibm.com>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent d149e3b2

mm/memcontrol.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -3348,10 +3348,9 @@ unsigned long mem_cgroup_soft_limit_reclaim(struct zone *zone, int order,
		*/
		next_mz =
		__mem_cgroup_largest_soft_limit_node(mctz);
		if (next_mz == mz) {
		if (next_mz == mz)
		css_put(&next_mz->mem->css);
		next_mz = NULL;
		} else /* next_mz == NULL or other memcg */
		else /* next_mz == NULL or other memcg */
		break;
		} while (1);
		}

Admin message