Commit 39c2d639 authored by Md Haris Iqbal's avatar Md Haris Iqbal Committed by Jason Gunthorpe
Browse files

RDMA/rtrs-srv: Set .release function for rtrs srv device during device init 

The device .release function was not being set during the device
initialization. This was leading to the below warning, in error cases when
put_srv was called before device_add was called.

Warning:

Device '(null)' does not have a release() function, it is broken and must
be fixed. See Documentation/kobject.txt.

So, set the device .release function during device initialization in the
__alloc_srv() function.

Fixes: baa5b28b ("RDMA/rtrs-srv: Replace device_register with device_initialize and device_add")
Link: https://lore.kernel.org/r/20200907102216.104041-1-haris.iqbal@cloud.ionos.com


Signed-off-by: default avatarMd Haris Iqbal <haris.iqbal@cloud.ionos.com>
Reviewed-by: default avatarLeon Romanovsky <leonro@nvidia.com>
Acked-by: default avatarJack Wang <jinpu.wang@cloud.ionos.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent 9e712446

drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c

+0 −8
Original line number Diff line number Diff line
@@ -152,13 +152,6 @@ static struct attribute_group rtrs_srv_stats_attr_group = { 
	.attrs = rtrs_srv_stats_attrs,

};



static void rtrs_srv_dev_release(struct device *dev)

{

	struct rtrs_srv *srv = container_of(dev, struct rtrs_srv, dev);



	kfree(srv);

}



static int rtrs_srv_create_once_sysfs_root_folders(struct rtrs_srv_sess *sess)

{

	struct rtrs_srv *srv = sess->srv;
@@ -172,7 +165,6 @@ static int rtrs_srv_create_once_sysfs_root_folders(struct rtrs_srv_sess *sess) 
		goto unlock;

	}

	srv->dev.class = rtrs_dev_class;

	srv->dev.release = rtrs_srv_dev_release;

	err = dev_set_name(&srv->dev, "%s", sess->s.sessname);

	if (err)

		goto unlock;

drivers/infiniband/ulp/rtrs/rtrs-srv.c

+8 −0
Original line number Diff line number Diff line
@@ -1319,6 +1319,13 @@ static int rtrs_srv_get_next_cq_vector(struct rtrs_srv_sess *sess) 
	return sess->cur_cq_vector;

}



static void rtrs_srv_dev_release(struct device *dev)

{

	struct rtrs_srv *srv = container_of(dev, struct rtrs_srv, dev);



	kfree(srv);

}



static struct rtrs_srv *__alloc_srv(struct rtrs_srv_ctx *ctx,

				     const uuid_t *paths_uuid)

{
@@ -1337,6 +1344,7 @@ static struct rtrs_srv *__alloc_srv(struct rtrs_srv_ctx *ctx, 
	srv->queue_depth = sess_queue_depth;

	srv->ctx = ctx;

	device_initialize(&srv->dev);

	srv->dev.release = rtrs_srv_dev_release;



	srv->chunks = kcalloc(srv->queue_depth, sizeof(*srv->chunks),

			      GFP_KERNEL);

CRA Git | Maintained and supported by SUSTech CRA and CCSE