Commit 39a2a2aa authored by Lv Zheng's avatar Lv Zheng Committed by Rafael J. Wysocki
Browse files

ACPI / EC: Add PM operations to improve event handling for suspend process 



In the original EC driver, though the event handling is not explicitly
stopped, the EC driver is actually not able to handle events during the
noirq stage as the EC driver is not prepared to handle the EC events in the
polling mode. So if there is no advance_transaction() triggered, the EC
driver couldn't notice the EC events.
However, do we actually need to handle EC events during suspend/resume
stage? EC events are mostly useless for the suspend/resume period (key
strokes and battery/thermal updates, etc.,), and the useful ones (lid
close, power/sleep button press) should have already been delivered to the
OSPM to trigger the power saving operations.
Thus this patch implements acpi_ec_disable_event() to be a reverse call of
acpi_ec_enable_event(), with which, the EC driver is able to stop handling
the EC events in a position before entering the noirq stage.

Since there are actually 2 choices for us:
1. implement event handling in polling mode;
2. stop event handling before entering noirq stage.
And this patch only implements the second choice using .suspend() callback.
Thus this is experimental (first choice is better? or different hook
position is better?). This patch finally keeps the old behavior by default
and prepares a boot parameter to enable this feature.

The differences of the event handling availability between the old behavior
(this patch is not applied) and the new behavior (this patch is applied)
are as follows:
                        !FreezeEvents   FreezeEvents
before suspend          Y               Y
suspend before EC       Y               Y
suspend after EC        Y               N
suspend_late            Y               N
suspend_noirq           Y (actually N)  N
resume_noirq            Y (actually N)  N
resume_late             Y (actually N)  N
resume before EC        Y (actually N)  N
resume after EC         Y               Y
after resume            Y               Y
Where "actually N" means if there is no EC transactions, the EC driver
is actually not able to notice the pending events.

We can see that FreezeEvents is the only approach now can actually flush
the EC event handling with both query commands and _Qxx evaluations
flushed, other modes can only flush the EC event handling with only query
commands flushed, _Qxx evaluations occurred after stopping the EC driver
may end up failure due to the failure of the EC transaction carried out in
the _Qxx control methods.

We also can see that this feature should be able to trigger some platform
notifications later than resuming other drivers.

Signed-off-by: default avatarLv Zheng <lv.zheng@intel.com>
Tested-by: default avatarTodd E Brandt <todd.e.brandt@linux.intel.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent c2b46d67

drivers/acpi/ec.c

+59 −5
Original line number Diff line number Diff line
@@ -146,6 +146,10 @@ static unsigned int ec_storm_threshold __read_mostly = 8; 
module_param(ec_storm_threshold, uint, 0644);

MODULE_PARM_DESC(ec_storm_threshold, "Maxim false GPE numbers not considered as GPE storm");



static bool ec_freeze_events __read_mostly = false;

module_param(ec_freeze_events, bool, 0644);

MODULE_PARM_DESC(ec_freeze_events, "Disabling event handling during suspend/resume");



struct acpi_ec_query_handler {

	struct list_head node;

	acpi_ec_query_func func;
@@ -250,9 +254,17 @@ static bool acpi_ec_event_enabled(struct acpi_ec *ec) 
	if (!test_bit(EC_FLAGS_QUERY_ENABLED, &ec->flags))

		return false;

	/*

	 * The EC event handling is automatically disabled as soon as the

	 * EC driver is stopped.

	 * However, disabling the event handling is experimental for late

	 * stage (suspend), and is controlled by the boot parameter of

	 * "ec_freeze_events":

	 * 1. true:  The EC event handling is disabled before entering

	 *           the noirq stage.

	 * 2. false: The EC event handling is automatically disabled as

	 *           soon as the EC driver is stopped.

	 */

	if (ec_freeze_events)

		return acpi_ec_started(ec);

	else

		return test_bit(EC_FLAGS_STARTED, &ec->flags);

}
@@ -512,6 +524,38 @@ static void acpi_ec_enable_event(struct acpi_ec *ec) 
		acpi_ec_clear(ec);

}



static bool acpi_ec_query_flushed(struct acpi_ec *ec)

{

	bool flushed;

	unsigned long flags;



	spin_lock_irqsave(&ec->lock, flags);

	flushed = !ec->nr_pending_queries;

	spin_unlock_irqrestore(&ec->lock, flags);

	return flushed;

}



static void __acpi_ec_flush_event(struct acpi_ec *ec)

{

	/*

	 * When ec_freeze_events is true, we need to flush events in

	 * the proper position before entering the noirq stage.

	 */

	wait_event(ec->wait, acpi_ec_query_flushed(ec));

	if (ec_query_wq)

		flush_workqueue(ec_query_wq);

}



static void acpi_ec_disable_event(struct acpi_ec *ec)

{

	unsigned long flags;



	spin_lock_irqsave(&ec->lock, flags);

	__acpi_ec_disable_event(ec);

	spin_unlock_irqrestore(&ec->lock, flags);

	__acpi_ec_flush_event(ec);

}



static bool acpi_ec_guard_event(struct acpi_ec *ec)

{

	bool guarded = true;
@@ -941,7 +985,7 @@ static void acpi_ec_stop(struct acpi_ec *ec, bool suspending) 
		if (!suspending) {

			acpi_ec_complete_request(ec);

			ec_dbg_ref(ec, "Decrease driver");

		} else

		} else if (!ec_freeze_events)

			__acpi_ec_disable_event(ec);

		clear_bit(EC_FLAGS_STARTED, &ec->flags);

		clear_bit(EC_FLAGS_STOPPED, &ec->flags);
@@ -1693,6 +1737,16 @@ static int acpi_ec_resume_noirq(struct device *dev) 
	return 0;

}



static int acpi_ec_suspend(struct device *dev)

{

	struct acpi_ec *ec =

		acpi_driver_data(to_acpi_device(dev));



	if (ec_freeze_events)

		acpi_ec_disable_event(ec);

	return 0;

}



static int acpi_ec_resume(struct device *dev)

{

	struct acpi_ec *ec =
@@ -1705,7 +1759,7 @@ static int acpi_ec_resume(struct device *dev) 


static const struct dev_pm_ops acpi_ec_pm = {

	SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(acpi_ec_suspend_noirq, acpi_ec_resume_noirq)

	SET_SYSTEM_SLEEP_PM_OPS(NULL, acpi_ec_resume)

	SET_SYSTEM_SLEEP_PM_OPS(acpi_ec_suspend, acpi_ec_resume)

};



static int param_set_event_clearing(const char *val, struct kernel_param *kp)

CRA Git | Maintained and supported by SUSTech CRA and CCSE