Commit 39946886 authored Feb 28, 2020 by Dan Carpenter Committed by Steve French Mar 17, 2020

cifs: potential unintitliazed error code in cifs_getattr()



Smatch complains that "rc" could be uninitialized.

    fs/cifs/inode.c:2206 cifs_getattr() error: uninitialized symbol 'rc'.

Changing it to "return 0;" improves readability as well.

Fixes: cc1baf98c8f6 ("cifs: do not ignore the SYNC flags in getattr")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Acked-by: Ronnie Sahlberg <lsahlber@redhat.com>

parent fb33c651

fs/cifs/inode.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2191,7 +2191,7 @@ int cifs_getattr(const struct path path, struct kstat stat,
		if (!(cifs_sb->mnt_cifs_flags & CIFS_MOUNT_OVERR_GID))
		stat->gid = current_fsgid();
		}
		return rc;
		return 0;
		}

		int cifs_fiemap(struct inode inode, struct fiemap_extent_info fei, u64 start,

Admin message