Commit 3991b31e authored May 28, 2014 by NeilBrown

md: always set MD_RECOVERY_INTR when aborting a reshape or other "resync".



If mddev->ro is set, md_to_sync will (correctly) abort.
However in that case MD_RECOVERY_INTR isn't set.

If a RESHAPE had been requested, then ->finish_reshape() will be
called and it will think the reshape was successful even though
nothing happened.

Normally a resync will not be requested if ->ro is set, but if an
array is stopped while a reshape is on-going, then when the array is
started, the reshape will be restarted.  If the array is also set
read-only at this point, the reshape will instantly appear to success,
resulting in data corruption.

Consequently, this patch is suitable for any -stable kernel.

Cc: stable@vger.kernel.org (any)
Signed-off-by: NeilBrown <neilb@suse.de>

parent c7208164

drivers/md/md.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -7381,8 +7381,10 @@ void md_do_sync(struct md_thread *thread)
		/* just incase thread restarts... */
		if (test_bit(MD_RECOVERY_DONE, &mddev->recovery))
		return;
		if (mddev->ro) /* never try to sync a read-only array */
		if (mddev->ro) {/* never try to sync a read-only array */
		set_bit(MD_RECOVERY_INTR, &mddev->recovery);
		return;
		}

		if (test_bit(MD_RECOVERY_SYNC, &mddev->recovery)) {
		if (test_bit(MD_RECOVERY_CHECK, &mddev->recovery)) {

Admin message