Commit 398bcbeb authored Jan 19, 2008 by YOSHIFUJI Hideaki Committed by David S. Miller Jan 20, 2008

[IPV6] ROUTE: Make sending algorithm more friendly with RFC 4861.



We omit (or delay) sending NSes for known-to-unreachable routers (in
NUD_FAILED state) according to RFC 4191 (Default Router Preferences
and More-Specific Routes).  But this is not fully compatible with RFC
4861 (Neighbor Discovery Protocol for IPv6), which does not remember
unreachability of neighbors.

So, let's avoid mixing sending algorithm of RFC 4191 and that of RFC
4861, and make the algorithm more friendly with RFC 4861 if RFC 4191
is disabled.

Issue was found by IPv6 Ready Logo Core Self_Test 1.5.0b2 (by TAHI
Project), and has been tracked down by Mitsuru Chinen
<mitch@linux.vnet.ibm.com>.

Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 8d3f099a

net/ipv6/route.c

+8 −3

Original line number	Diff line number	Diff line
		@@ -329,7 +329,7 @@ static inline int rt6_check_dev(struct rt6_info *rt, int oif)
		static inline int rt6_check_neigh(struct rt6_info *rt)
		{
		struct neighbour *neigh = rt->rt6i_nexthop;
		int m = 0;
		int m;
		if (rt->rt6i_flags & RTF_NONEXTHOP \|\|
		!(rt->rt6i_flags & RTF_GATEWAY))
		m = 1;
		@@ -337,10 +337,15 @@ static inline int rt6_check_neigh(struct rt6_info *rt)
		read_lock_bh(&neigh->lock);
		if (neigh->nud_state & NUD_VALID)
		m = 2;
		else if (!(neigh->nud_state & NUD_FAILED))
		#ifdef CONFIG_IPV6_ROUTER_PREF
		else if (neigh->nud_state & NUD_FAILED)
		m = 0;
		#endif
		else
		m = 1;
		read_unlock_bh(&neigh->lock);
		}
		} else
		m = 0;
		return m;
		}

Admin message