Commit 39773722 authored Nov 13, 2015 by Martin K. Petersen

sd: Make discard granularity match logical block size when LBPRZ=1



A device may report an OPTIMAL UNMAP GRANULARITY and UNMAP GRANULARITY
ALIGNMENT in the Block Limits VPD. These parameters describe the
device's internal provisioning allocation units. By default the block
layer will round and align any discard requests based on these limits.

If a device reports LBPRZ=1 to guarantee zeroes after discard, however,
it is imperative that the block layer does not leave out any parts of
the requested block range. Otherwise the device can not do the required
zeroing of any partial allocation units and this can lead to data
corruption.

Since the dm thinp personality relies on the block layer's current
behavior and is unable to deal with partial discard blocks we work
around the problem by setting the granularity to match the logical block
size when LBPRZ is enabled.

Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 653cfb85

drivers/scsi/sd.c

+18 −5

Original line number	Diff line number	Diff line
		@@ -637,11 +637,24 @@ static void sd_config_discard(struct scsi_disk *sdkp, unsigned int mode)
		unsigned int max_blocks = 0;

		q->limits.discard_zeroes_data = 0;

		/*
		* When LBPRZ is reported, discard alignment and granularity
		* must be fixed to the logical block size. Otherwise the block
		* layer will drop misaligned portions of the request which can
		* lead to data corruption. If LBPRZ is not set, we honor the
		* device preference.
		*/
		if (sdkp->lbprz) {
		q->limits.discard_alignment = 0;
		q->limits.discard_granularity = 1;
		} else {
		q->limits.discard_alignment = sdkp->unmap_alignment *
		logical_block_size;
		q->limits.discard_granularity =
		max(sdkp->physical_block_size,
		sdkp->unmap_granularity * logical_block_size);
		}

		sdkp->provisioning_mode = mode;

Admin message