USB: serial: ti_usb_3410_5052: fix control-message error handling (39712e8b) · Commits · 戴 / test

Make sure to detect and return an error on zero-length control-message transfers when reading from the device. This addresses a potential failure to detect an empty transmit buffer during close. Also remove a redundant check for short transfer when sending a command. Fixes: ("Linux-2.6.12-rc2") Reviewed-by:

Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by:

Johan Hovold <johan@kernel.org>

drivers/usb/serial/ti_usb_3410_5052.c

+4 −8

Original line number	Diff line number	Diff line
		@@ -1553,13 +1553,10 @@ static int ti_command_out_sync(struct ti_device *tdev, __u8 command,
		(USB_TYPE_VENDOR \| USB_RECIP_DEVICE \| USB_DIR_OUT),
		value, moduleid, data, size, 1000);

		if (status == size)
		status = 0;

		if (status > 0)
		status = -ECOMM;

		if (status < 0)
		return status;

		return 0;
		}


		@@ -1575,8 +1572,7 @@ static int ti_command_in_sync(struct ti_device *tdev, __u8 command,

		if (status == size)
		status = 0;

		if (status > 0)
		else if (status >= 0)
		status = -ECOMM;

		return status;

Admin message