staging: unisys: visorbus: relocate error-check from isr to registration (396e36c9) · Commits · 戴 / test

It just makes more sense to do the NULL-pointer check when the function is called to enable interrupts, rather than on *every* interrupt. Signed-off-by:

Tim Sell <Timothy.Sell@unisys.com> Signed-off-by:

David Kershner <david.kershner@unisys.com> Signed-off-by:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/staging/unisys/visorbus/visorbus_main.c

+8 −2

Original line number	Diff line number	Diff line
		@@ -438,7 +438,6 @@ dev_periodic_work(unsigned long __opaque)
		struct visor_device dev = (struct visor_device )__opaque;
		struct visor_driver *drv = to_visor_driver(dev->device.driver);

		if (drv->channel_interrupt)
		drv->channel_interrupt(dev);
		mod_timer(&dev->timer, jiffies + POLLJIFFIES_NORMALCHANNEL);
		}
		@@ -561,6 +560,13 @@ EXPORT_SYMBOL_GPL(visorbus_write_channel);
		void
		visorbus_enable_channel_interrupts(struct visor_device *dev)
		{
		struct visor_driver *drv = to_visor_driver(dev->device.driver);

		if (!drv->channel_interrupt) {
		dev_err(&dev->device, "%s no interrupt function!\n", __func__);
		return;
		}

		dev_start_periodic_work(dev);
		}
		EXPORT_SYMBOL_GPL(visorbus_enable_channel_interrupts);

Admin message