Commit 3944a927 authored May 15, 2014 by Ben Segall Committed by Ingo Molnar May 22, 2014

sched: Fix exec_start/task_hot on migrated tasks



task_hot checks exec_start on any runnable task, but if it has been
migrated since the it last ran, then exec_start is a clock_task from
another cpu. If the old cpu's clock_task was sufficiently far ahead of
this cpu's then the task will not be considered for another migration
until it has run. Instead reset exec_start whenever a task is migrated,
since it is presumably no longer hot anyway.

Signed-off-by: Ben Segall <bsegall@google.com>
[ Made it compile. ]
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: http://lkml.kernel.org/r/20140515225920.7179.13924.stgit@sword-of-the-dawn.mtv.corp.google.com


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent 6669dc89

kernel/sched/fair.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -4544,6 +4544,9 @@ migrate_task_rq_fair(struct task_struct *p, int next_cpu)
		atomic_long_add(se->avg.load_avg_contrib,
		&cfs_rq->removed_load);
		}

		/* We have migrated, no longer consider this task hot */
		se->exec_start = 0;
		}
		#endif /* CONFIG_SMP */

Admin message