Commit 3942a9bd authored Aug 11, 2016 by Peter Zijlstra Committed by Ingo Molnar Aug 18, 2016

locking, rcu, cgroup: Avoid synchronize_sched() in __cgroup_procs_write()



The current percpu-rwsem read side is entirely free of serializing insns
at the cost of having a synchronize_sched() in the write path.

The latency of the synchronize_sched() is too high for cgroups. The
commit 1ed13287 talks about the write path being a fairly cold path
but this is not the case for Android which moves task to the foreground
cgroup and back around binder IPC calls from foreground processes to
background processes, so it is significantly hotter than human initiated
operations.

Switch cgroup_threadgroup_rwsem into the slow mode for now to avoid the
problem, hopefully it should not be that slow after another commit:

  80127a39 ("locking/percpu-rwsem: Optimize readers and reduce global impact").

We could just add rcu_sync_enter() into cgroup_init() but we do not want
another synchronize_sched() at boot time, so this patch adds the new helper
which doesn't block but currently can only be called before the first use.

Reported-by: John Stultz <john.stultz@linaro.org>
Reported-by: Dmitry Shmidt <dimitrysh@google.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Colin Cross <ccross@google.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Rom Lemarchand <romlem@google.com>
Cc: Tejun Heo <tj@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Todd Kjos <tkjos@google.com>
Link: http://lkml.kernel.org/r/20160811165413.GA22807@redhat.com


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent e8cb0fe6

include/linux/rcu_sync.h

+1 −0

Original line number	Diff line number	Diff line
		@@ -59,6 +59,7 @@ static inline bool rcu_sync_is_idle(struct rcu_sync *rsp)
		}

		extern void rcu_sync_init(struct rcu_sync *, enum rcu_sync_type);
		extern void rcu_sync_enter_start(struct rcu_sync *);
		extern void rcu_sync_enter(struct rcu_sync *);
		extern void rcu_sync_exit(struct rcu_sync *);
		extern void rcu_sync_dtor(struct rcu_sync *);

kernel/cgroup.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -5606,6 +5606,12 @@ int __init cgroup_init(void)
		BUG_ON(cgroup_init_cftypes(NULL, cgroup_dfl_base_files));
		BUG_ON(cgroup_init_cftypes(NULL, cgroup_legacy_base_files));

		/*
		* The latency of the synchronize_sched() is too high for cgroups,
		* avoid it at the cost of forcing all readers into the slow path.
		*/
		rcu_sync_enter_start(&cgroup_threadgroup_rwsem.rss);

		get_user_ns(init_cgroup_ns.user_ns);

		mutex_lock(&cgroup_mutex);

kernel/rcu/sync.c

+12 −0

Original line number	Diff line number	Diff line
		@@ -84,6 +84,18 @@ void rcu_sync_init(struct rcu_sync *rsp, enum rcu_sync_type type)
		rsp->gp_type = type;
		}

		/**
		* Must be called after rcu_sync_init() and before first use.
		*
		* Ensures rcu_sync_is_idle() returns false and rcu_sync_{enter,exit}()
		* pairs turn into NO-OPs.
		*/
		void rcu_sync_enter_start(struct rcu_sync *rsp)
		{
		rsp->gp_count++;
		rsp->gp_state = GP_PASSED;
		}

		/**
		* rcu_sync_enter() - Force readers onto slowpath
		* @rsp: Pointer to rcu_sync structure to use for synchronization

Admin message