leds: leds-pwm: properly clean up after probe failure (39236901) · Commits · 戴 / test

When probing with DT, we add each LED one at a time. If we find a LED without a PWM device (because it is not available yet) we fail the initialisation, unregister previous LEDs, and then by way of managed resources, we free the structure. The problem with this is we may have a scheduled and active work_struct in this structure, and this results in a nasty kernel oops. We need to cancel this work_struct properly upon cleanup - and the cleanup we require is the same cleanup as we do when the LED platform device is removed. Rather than writing this same code three times, move it into a separate function and use it in all three places. Fixes: ("leds: leds-pwm: Defer led_pwm_set() if PWM can sleep") Signed-off-by:

Russell King <rmk+kernel@arm.linux.org.uk> Signed-off-by:

Bryan Wu <cooloney@gmail.com>

drivers/leds/leds-pwm.c

+13 −10

Original line number	Diff line number	Diff line
		@@ -83,6 +83,15 @@ static inline size_t sizeof_pwm_leds_priv(int num_leds)
		(sizeof(struct led_pwm_data) * num_leds);
		}

		static void led_pwm_cleanup(struct led_pwm_priv *priv)
		{
		while (priv->num_leds--) {
		led_classdev_unregister(&priv->leds[priv->num_leds].cdev);
		if (priv->leds[priv->num_leds].can_sleep)
		cancel_work_sync(&priv->leds[priv->num_leds].work);
		}
		}

		static int led_pwm_create_of(struct platform_device *pdev,
		struct led_pwm_priv *priv)
		{
		@@ -130,8 +139,7 @@ static int led_pwm_create_of(struct platform_device *pdev,

		return 0;
		err:
		while (priv->num_leds--)
		led_classdev_unregister(&priv->leds[priv->num_leds].cdev);
		led_pwm_cleanup(priv);

		return ret;
		}
		@@ -199,8 +207,8 @@ static int led_pwm_probe(struct platform_device *pdev)
		return 0;

		err:
		while (i--)
		led_classdev_unregister(&priv->leds[i].cdev);
		priv->num_leds = i;
		led_pwm_cleanup(priv);

		return ret;
		}
		@@ -208,13 +216,8 @@ err:
		static int led_pwm_remove(struct platform_device *pdev)
		{
		struct led_pwm_priv *priv = platform_get_drvdata(pdev);
		int i;

		for (i = 0; i < priv->num_leds; i++) {
		led_classdev_unregister(&priv->leds[i].cdev);
		if (priv->leds[i].can_sleep)
		cancel_work_sync(&priv->leds[i].work);
		}
		led_pwm_cleanup(priv);

		return 0;
		}

Admin message