Commit 391a2033 authored Apr 21, 2016 by Paolo Abeni Committed by David S. Miller Apr 24, 2016

ipv4/fib: don't warn when primary address is missing if in_dev is dead



After commit fbd40ea0 ("ipv4: Don't do expensive useless work
during inetdev destroy.") when deleting an interface,
fib_del_ifaddr() can be executed without any primary address
present on the dead interface.

The above is safe, but triggers some "bug: prim == NULL" warnings.

This commit avoids warning if the in_dev is dead

Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 91e019de

net/ipv4/fib_frontend.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -904,6 +904,10 @@ void fib_del_ifaddr(struct in_ifaddr ifa, struct in_ifaddr iprim)
		if (ifa->ifa_flags & IFA_F_SECONDARY) {
		prim = inet_ifa_byprefix(in_dev, any, ifa->ifa_mask);
		if (!prim) {
		/* if the device has been deleted, we don't perform
		* address promotion
		*/
		if (!in_dev->dead)
		pr_warn("%s: bug: prim == NULL\n", __func__);
		return;
		}

Admin message