Commit 39186cbe authored May 13, 2019 by Oscar Salvador Committed by Linus Torvalds May 14, 2019

mm,memory_hotplug: drop redundant hugepage_migration_supported check

has_unmovable_pages() already checks whether the hugetlb page supports
migration, so all non-migratable hugetlb pages should have been caught
there.  Let us drop the check from scan_movable_pages() as is redundant.

Link: http://lkml.kernel.org/r/20190320152658.10855-3-osalvador@suse.de


Signed-off-by: Oscar Salvador <osalvador@suse.de>
Acked-by: Michal Hocko <mhocko@suse.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Cc: Mike Kravetz <mike.kravetz@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 10eeadf3

mm/memory_hotplug.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -1341,8 +1341,7 @@ static unsigned long scan_movable_pages(unsigned long start, unsigned long end)
		if (!PageHuge(page))
		continue;
		head = compound_head(page);
		if (hugepage_migration_supported(page_hstate(head)) &&
		page_huge_active(head))
		if (page_huge_active(head))
		return pfn;
		skip = (1 << compound_order(head)) - (page - head);
		pfn += skip - 1;

Admin message