Commit 38e712ab authored May 26, 2010 by Julia Lawall Committed by Alex Elder May 28, 2010

fs/xfs/quota: Add missing mutex_unlock

Add a mutex_unlock missing on the error path.  The use of this lock
is balanced elsewhere in the file.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression E1;
@@

* mutex_lock(E1,...);
  <+... when != E1
  if (...) {
    ... when != E1
*   return ...;
  }
  ...+>
* mutex_unlock(E1,...);
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Alex Elder <aelder@sgi.com>

parent 3bd0946e

fs/xfs/quota/xfs_qm.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -249,9 +249,11 @@ xfs_qm_hold_quotafs_ref(

		if (!xfs_Gqm) {
		xfs_Gqm = xfs_Gqm_init();
		if (!xfs_Gqm)
		if (!xfs_Gqm) {
		mutex_unlock(&xfs_Gqm_lock);
		return ENOMEM;
		}
		}

		/*
		* We can keep a list of all filesystems with quotas mounted for

Admin message