Commit 38d7f688 authored Sep 04, 2013 by Xenia Ragiadakou Committed by Sarah Sharp Sep 23, 2013

usbcore: check usb device's state before sending a Set SEL control transfer



Set SEL control urbs cannot be sent to a device in unconfigured state.
This patch adds a check in usb_req_set_sel() to ensure the usb device's
state is USB_STATE_CONFIGURED.

Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
Reported-by: Martin MOKREJS <mmokrejs@gmail.com>
Suggested-by: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Signed-off-by: Sarah Sharp <sarah.a.sharp@linux.intel.com>

parent 526867c3

drivers/usb/core/hub.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -3426,6 +3426,9 @@ static int usb_req_set_sel(struct usb_device *udev, enum usb3_link_state state)
		unsigned long long u2_pel;
		int ret;

		if (udev->state != USB_STATE_CONFIGURED)
		return 0;

		/* Convert SEL and PEL stored in ns to us */
		u1_sel = DIV_ROUND_UP(udev->u1_params.sel, 1000);
		u1_pel = DIV_ROUND_UP(udev->u1_params.pel, 1000);

Admin message