Commit 38bb6b28 authored by John W. Linville's avatar John W. Linville Committed by Jeff Garzik
Browse files

[PATCH] via-rhine: revert "change mdelay to msleep and remove from ISR path" 

Revert previous patch with subject "change mdelay to msleep and remove
from ISR path".  This patch seems to have caused bigger problems than
it solved, and it didn't solve much of a problem to begin with...

Discussion about backing-out this patch can be found here:

	http://marc.theaimsgroup.com/?l=linux-netdev&m=114321570402396&w=2



The git commit associated w/ the original patch is:

	6ba98d31

Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
parent f34ba4e1

drivers/net/via-rhine.c

+3 −31
Original line number Diff line number Diff line
@@ -491,8 +491,6 @@ struct rhine_private { 
	u8 tx_thresh, rx_thresh;



	struct mii_if_info mii_if;

	struct work_struct tx_timeout_task;

	struct work_struct check_media_task;

	void __iomem *base;

};
@@ -500,8 +498,6 @@ static int mdio_read(struct net_device *dev, int phy_id, int location); 
static void mdio_write(struct net_device *dev, int phy_id, int location, int value);

static int  rhine_open(struct net_device *dev);

static void rhine_tx_timeout(struct net_device *dev);

static void rhine_tx_timeout_task(struct net_device *dev);

static void rhine_check_media_task(struct net_device *dev);

static int  rhine_start_tx(struct sk_buff *skb, struct net_device *dev);

static irqreturn_t rhine_interrupt(int irq, void *dev_instance, struct pt_regs *regs);

static void rhine_tx(struct net_device *dev);
@@ -856,12 +852,6 @@ static int __devinit rhine_init_one(struct pci_dev *pdev, 
	if (rp->quirks & rqRhineI)

		dev->features |= NETIF_F_SG|NETIF_F_HW_CSUM;



	INIT_WORK(&rp->tx_timeout_task,

		  (void (*)(void *))rhine_tx_timeout_task, dev);



	INIT_WORK(&rp->check_media_task,

		  (void (*)(void *))rhine_check_media_task, dev);



	/* dev->name not defined before register_netdev()! */

	rc = register_netdev(dev);

	if (rc)
@@ -1108,11 +1098,6 @@ static void rhine_set_carrier(struct mii_if_info *mii) 
		       netif_carrier_ok(mii->dev));

}



static void rhine_check_media_task(struct net_device *dev)

{

	rhine_check_media(dev, 0);

}



static void init_registers(struct net_device *dev)

{

	struct rhine_private *rp = netdev_priv(dev);
@@ -1166,8 +1151,8 @@ static void rhine_disable_linkmon(void __iomem *ioaddr, u32 quirks) 
	if (quirks & rqRhineI) {

		iowrite8(0x01, ioaddr + MIIRegAddr);	// MII_BMSR



		/* Do not call from ISR! */

		msleep(1);

		/* Can be called from ISR. Evil. */

		mdelay(1);



		/* 0x80 must be set immediately before turning it off */

		iowrite8(0x80, ioaddr + MIICmd);
@@ -1255,16 +1240,6 @@ static int rhine_open(struct net_device *dev) 
}



static void rhine_tx_timeout(struct net_device *dev)

{

	struct rhine_private *rp = netdev_priv(dev);



	/*

	 * Move bulk of work outside of interrupt context

	 */

	schedule_work(&rp->tx_timeout_task);

}



static void rhine_tx_timeout_task(struct net_device *dev)

{

	struct rhine_private *rp = netdev_priv(dev);

	void __iomem *ioaddr = rp->base;
@@ -1677,7 +1652,7 @@ static void rhine_error(struct net_device *dev, int intr_status) 
	spin_lock(&rp->lock);



	if (intr_status & IntrLinkChange)

		schedule_work(&rp->check_media_task);

		rhine_check_media(dev, 0);

	if (intr_status & IntrStatsMax) {

		rp->stats.rx_crc_errors += ioread16(ioaddr + RxCRCErrs);

		rp->stats.rx_missed_errors += ioread16(ioaddr + RxMissed);
@@ -1927,9 +1902,6 @@ static int rhine_close(struct net_device *dev) 
	spin_unlock_irq(&rp->lock);



	free_irq(rp->pdev->irq, dev);



	flush_scheduled_work();



	free_rbufs(dev);

	free_tbufs(dev);

	free_ring(dev);

CRA Git | Maintained and supported by SUSTech CRA and CCSE