drm/amdkfd: Fix sdma queue allocate race condition (38bb4226) · Commits · 戴 / test

SDMA queue allocation requires the dqm lock as it modify the global dqm members. Enclose it in the dqm_lock. Signed-off-by:

drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c

+6 −1

Original line number	Diff line number	Diff line
		@@ -1144,7 +1144,9 @@ static int create_queue_cpsch(struct device_queue_manager dqm, struct queue q,

		if (q->properties.type == KFD_QUEUE_TYPE_SDMA \|\|
		q->properties.type == KFD_QUEUE_TYPE_SDMA_XGMI) {
		dqm_lock(dqm);
		retval = allocate_sdma_queue(dqm, q);
		dqm_unlock(dqm);
		if (retval)
		goto out;
		}
		@@ -1203,8 +1205,11 @@ out_deallocate_doorbell:
		deallocate_doorbell(qpd, q);
		out_deallocate_sdma_queue:
		if (q->properties.type == KFD_QUEUE_TYPE_SDMA \|\|
		q->properties.type == KFD_QUEUE_TYPE_SDMA_XGMI)
		q->properties.type == KFD_QUEUE_TYPE_SDMA_XGMI) {
		dqm_lock(dqm);
		deallocate_sdma_queue(dqm, q);
		dqm_unlock(dqm);
		}
		out:
		return retval;
		}