Commit 38b65190 authored Aug 19, 2011 by Takashi Iwai

ALSA: usb-audio - Fix missing mixer dB information

The recent fix for testing dB range at the mixer creation time seems
to cause regressions in some devices. In such devices, reading the dB
info at probing time gives an error, thus both dBmin and dBmax are still
zero, and TLV flag isn't set although the later read of dB info succeeds.

This patch adds a workaround for such a case by assuming that the later
read will succeed. In future, a similar test should be performed in a
case where a wrong dB range is seen even in the later read.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Cc: <stable@kernel.org>

parent 3fe45aea

sound/usb/mixer.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -152,6 +152,7 @@ static inline void check_mapped_dB(const struct usbmix_name_map *p,
		if (p && p->dB) {
		cval->dBmin = p->dB->min;
		cval->dBmax = p->dB->max;
		cval->initialized = 1;
		}
		}

		@@ -1092,7 +1093,7 @@ static void build_feature_ctl(struct mixer_build state, void raw_desc,
		" Switch" : " Volume");
		if (control == UAC_FU_VOLUME) {
		check_mapped_dB(map, cval);
		if (cval->dBmin < cval->dBmax) {
		if (cval->dBmin < cval->dBmax \|\| !cval->initialized) {
		kctl->tlv.c = mixer_vol_tlv;
		kctl->vd[0].access \|=
		SNDRV_CTL_ELEM_ACCESS_TLV_READ \|

Admin message