Commit 38971ce2 authored by Linus Torvalds's avatar Linus Torvalds
Browse files

Merge branch 'bugfixes' of git://git.linux-nfs.org/projects/trondmy/nfs-2.6 

* 'bugfixes' of git://git.linux-nfs.org/projects/trondmy/nfs-2.6:
  NFS: Fix panic after nfs_umount()
  nfs: remove extraneous and problematic calls to nfs_clear_request
  nfs: kernel should return EPROTONOSUPPORT when not support NFSv4
  NFS: Fix fcntl F_GETLK not reporting some conflicts
  nfs: Discard ACL cache on mode update
  NFS: Readdir cleanups
  NFS: nfs_readdir_search_for_cookie() don't mark as eof if cookie not found
  NFS: Fix a memory leak in nfs_readdir
  Call the filesystem back whenever a page is removed from the page cache
  NFS: Ensure we use the correct cookie in nfs_readdir_xdr_filler
parents caa4a595 5b362ac3

Documentation/filesystems/Locking

+6 −1
Original line number Diff line number Diff line
@@ -173,12 +173,13 @@ prototypes: 
	sector_t (*bmap)(struct address_space *, sector_t);

	int (*invalidatepage) (struct page *, unsigned long);

	int (*releasepage) (struct page *, int);

	void (*freepage)(struct page *);

	int (*direct_IO)(int, struct kiocb *, const struct iovec *iov,

			loff_t offset, unsigned long nr_segs);

	int (*launder_page) (struct page *);



locking rules:

	All except set_page_dirty may block

	All except set_page_dirty and freepage may block



			BKL	PageLocked(page)	i_mutex

writepage:		no	yes, unlocks (see below)
@@ -193,6 +194,7 @@ perform_write: no n/a yes 
bmap:			no

invalidatepage:		no	yes

releasepage:		no	yes

freepage:		no	yes

direct_IO:		no

launder_page:		no	yes
@@ -288,6 +290,9 @@ buffers from the page in preparation for freeing it. It returns zero to 
indicate that the buffers are (or may be) freeable.  If ->releasepage is zero,

the kernel assumes that the fs has no private interest in the buffers.



	->freepage() is called when the kernel is done dropping the page

from the page cache.



	->launder_page() may be called prior to releasing a page if

it is still found to be dirty. It returns zero if the page was successfully

cleaned, or an error value if not. Note that in order to prevent the page

Documentation/filesystems/vfs.txt

+7 −0
Original line number Diff line number Diff line
@@ -534,6 +534,7 @@ struct address_space_operations { 
	sector_t (*bmap)(struct address_space *, sector_t);

	int (*invalidatepage) (struct page *, unsigned long);

	int (*releasepage) (struct page *, int);

	void (*freepage)(struct page *);

	ssize_t (*direct_IO)(int, struct kiocb *, const struct iovec *iov,

			loff_t offset, unsigned long nr_segs);

	struct page* (*get_xip_page)(struct address_space *, sector_t,
@@ -678,6 +679,12 @@ struct address_space_operations { 
        need to ensure this.  Possibly it can clear the PageUptodate

        bit if it cannot free private data yet.



  freepage: freepage is called once the page is no longer visible in

        the page cache in order to allow the cleanup of any private

	data. Since it may be called by the memory reclaimer, it

	should not assume that the original address_space mapping still

	exists, and it should not block.



  direct_IO: called by the generic read/write routines to perform

        direct_IO - that is IO requests which bypass the page cache

        and transfer data directly between the storage and the

fs/nfs/dir.c

+35 −41
Original line number Diff line number Diff line
@@ -57,7 +57,7 @@ static int nfs_rename(struct inode *, struct dentry *, 
		      struct inode *, struct dentry *);

static int nfs_fsync_dir(struct file *, int);

static loff_t nfs_llseek_dir(struct file *, loff_t, int);

static int nfs_readdir_clear_array(struct page*, gfp_t);

static void nfs_readdir_clear_array(struct page*);



const struct file_operations nfs_dir_operations = {

	.llseek		= nfs_llseek_dir,
@@ -83,8 +83,8 @@ const struct inode_operations nfs_dir_inode_operations = { 
	.setattr	= nfs_setattr,

};



const struct address_space_operations nfs_dir_addr_space_ops = {

	.releasepage = nfs_readdir_clear_array,

const struct address_space_operations nfs_dir_aops = {

	.freepage = nfs_readdir_clear_array,

};



#ifdef CONFIG_NFS_V3
@@ -178,6 +178,7 @@ typedef struct { 
	struct page	*page;

	unsigned long	page_index;

	u64		*dir_cookie;

	u64		last_cookie;

	loff_t		current_index;

	decode_dirent_t	decode;
@@ -213,17 +214,15 @@ void nfs_readdir_release_array(struct page *page) 
 * we are freeing strings created by nfs_add_to_readdir_array()

 */

static

int nfs_readdir_clear_array(struct page *page, gfp_t mask)

void nfs_readdir_clear_array(struct page *page)

{

	struct nfs_cache_array *array = nfs_readdir_get_array(page);

	struct nfs_cache_array *array;

	int i;



	if (IS_ERR(array))

		return PTR_ERR(array);

	array = kmap_atomic(page, KM_USER0);

	for (i = 0; i < array->size; i++)

		kfree(array->array[i].string.name);

	nfs_readdir_release_array(page);

	return 0;

	kunmap_atomic(array, KM_USER0);

}



/*
@@ -272,7 +271,7 @@ int nfs_readdir_add_to_array(struct nfs_entry *entry, struct page *page) 
		goto out;

	array->last_cookie = entry->cookie;

	array->size++;

	if (entry->eof == 1)

	if (entry->eof != 0)

		array->eof_index = array->size;

out:

	nfs_readdir_release_array(page);
@@ -312,15 +311,14 @@ int nfs_readdir_search_for_cookie(struct nfs_cache_array *array, nfs_readdir_des 
	for (i = 0; i < array->size; i++) {

		if (array->array[i].cookie == *desc->dir_cookie) {

			desc->cache_entry_index = i;

			status = 0;

			goto out;

			return 0;

		}

	}

	if (i == array->eof_index) {

		desc->eof = 1;

	if (array->eof_index >= 0) {

		status = -EBADCOOKIE;

		if (*desc->dir_cookie == array->last_cookie)

			desc->eof = 1;

	}

out:

	return status;

}
@@ -328,10 +326,7 @@ static 
int nfs_readdir_search_array(nfs_readdir_descriptor_t *desc)

{

	struct nfs_cache_array *array;

	int status = -EBADCOOKIE;



	if (desc->dir_cookie == NULL)

		goto out;

	int status;



	array = nfs_readdir_get_array(desc->page);

	if (IS_ERR(array)) {
@@ -344,6 +339,10 @@ int nfs_readdir_search_array(nfs_readdir_descriptor_t *desc) 
	else

		status = nfs_readdir_search_for_cookie(array, desc);



	if (status == -EAGAIN) {

		desc->last_cookie = array->last_cookie;

		desc->page_index++;

	}

	nfs_readdir_release_array(desc->page);

out:

	return status;
@@ -490,7 +489,7 @@ int nfs_readdir_page_filler(nfs_readdir_descriptor_t *desc, struct nfs_entry *en 


		count++;



		if (desc->plus == 1)

		if (desc->plus != 0)

			nfs_prime_dcache(desc->file->f_path.dentry, entry);



		status = nfs_readdir_add_to_array(entry, page);
@@ -498,7 +497,7 @@ int nfs_readdir_page_filler(nfs_readdir_descriptor_t *desc, struct nfs_entry *en 
			break;

	} while (!entry->eof);



	if (count == 0 || (status == -EBADCOOKIE && entry->eof == 1)) {

	if (count == 0 || (status == -EBADCOOKIE && entry->eof != 0)) {

		array = nfs_readdir_get_array(page);

		if (!IS_ERR(array)) {

			array->eof_index = array->size;
@@ -563,7 +562,7 @@ int nfs_readdir_xdr_to_array(nfs_readdir_descriptor_t *desc, struct page *page, 
	unsigned int array_size = ARRAY_SIZE(pages);



	entry.prev_cookie = 0;

	entry.cookie = *desc->dir_cookie;

	entry.cookie = desc->last_cookie;

	entry.eof = 0;

	entry.fh = nfs_alloc_fhandle();

	entry.fattr = nfs_alloc_fattr();
@@ -636,6 +635,8 @@ int nfs_readdir_filler(nfs_readdir_descriptor_t *desc, struct page* page) 
static

void cache_page_release(nfs_readdir_descriptor_t *desc)

{

	if (!desc->page->mapping)

		nfs_readdir_clear_array(desc->page);

	page_cache_release(desc->page);

	desc->page = NULL;

}
@@ -660,8 +661,7 @@ int find_cache_page(nfs_readdir_descriptor_t *desc) 
		return PTR_ERR(desc->page);



	res = nfs_readdir_search_array(desc);

	if (res == 0)

		return 0;

	if (res != 0)

		cache_page_release(desc);

	return res;

}
@@ -672,22 +672,16 @@ int readdir_search_pagecache(nfs_readdir_descriptor_t *desc) 
{

	int res;



	if (desc->page_index == 0)

	if (desc->page_index == 0) {

		desc->current_index = 0;

	while (1) {

		res = find_cache_page(desc);

		if (res != -EAGAIN)

			break;

		desc->page_index++;

		desc->last_cookie = 0;

	}

	do {

		res = find_cache_page(desc);

	} while (res == -EAGAIN);

	return res;

}



static inline unsigned int dt_type(struct inode *inode)

{

	return (inode->i_mode >> 12) & 15;

}



/*

 * Once we've found the start of the dirent within a page: fill 'er up...

 */
@@ -717,13 +711,12 @@ int nfs_do_filldir(nfs_readdir_descriptor_t *desc, void *dirent, 
			break;

		}

		file->f_pos++;

		desc->cache_entry_index = i;

		if (i < (array->size-1))

			*desc->dir_cookie = array->array[i+1].cookie;

		else

			*desc->dir_cookie = array->last_cookie;

	}

	if (i == array->eof_index)

	if (array->eof_index >= 0)

		desc->eof = 1;



	nfs_readdir_release_array(desc->page);
@@ -764,6 +757,7 @@ int uncached_readdir(nfs_readdir_descriptor_t *desc, void *dirent, 
	}



	desc->page_index = 0;

	desc->last_cookie = *desc->dir_cookie;

	desc->page = page;



	status = nfs_readdir_xdr_to_array(desc, page, inode);
@@ -791,7 +785,7 @@ static int nfs_readdir(struct file *filp, void *dirent, filldir_t filldir) 
	struct inode	*inode = dentry->d_inode;

	nfs_readdir_descriptor_t my_desc,

			*desc = &my_desc;

	int res = -ENOMEM;

	int res;



	dfprintk(FILE, "NFS: readdir(%s/%s) starting at cookie %llu\n",

			dentry->d_parent->d_name.name, dentry->d_name.name,
@@ -816,7 +810,7 @@ static int nfs_readdir(struct file *filp, void *dirent, filldir_t filldir) 
	if (res < 0)

		goto out;



	while (desc->eof != 1) {

	do {

		res = readdir_search_pagecache(desc);



		if (res == -EBADCOOKIE) {
@@ -844,7 +838,7 @@ static int nfs_readdir(struct file *filp, void *dirent, filldir_t filldir) 
		res = nfs_do_filldir(desc, dirent, filldir);

		if (res < 0)

			break;

	}

	} while (!desc->eof);

out:

	nfs_unblock_sillyrename(dentry);

	if (res > 0)

fs/nfs/file.c

+2 −0
Original line number Diff line number Diff line
@@ -693,6 +693,7 @@ do_getlk(struct file *filp, int cmd, struct file_lock *fl, int is_local) 
{

	struct inode *inode = filp->f_mapping->host;

	int status = 0;

	unsigned int saved_type = fl->fl_type;



	/* Try local locking first */

	posix_test_lock(filp, fl);
@@ -700,6 +701,7 @@ do_getlk(struct file *filp, int cmd, struct file_lock *fl, int is_local) 
		/* found a conflict */

		goto out;

	}

	fl->fl_type = saved_type;



	if (nfs_have_delegation(inode, FMODE_READ))

		goto out_noconflict;

fs/nfs/inode.c

+1 −0
Original line number Diff line number Diff line
@@ -289,6 +289,7 @@ nfs_fhget(struct super_block *sb, struct nfs_fh *fh, struct nfs_fattr *fattr) 
		} else if (S_ISDIR(inode->i_mode)) {

			inode->i_op = NFS_SB(sb)->nfs_client->rpc_ops->dir_inode_ops;

			inode->i_fop = &nfs_dir_operations;

			inode->i_data.a_ops = &nfs_dir_aops;

			if (nfs_server_capable(inode, NFS_CAP_READDIRPLUS))

				set_bit(NFS_INO_ADVISE_RDPLUS, &NFS_I(inode)->flags);

			/* Deal with crossing mountpoints */

CRA Git | Maintained and supported by SUSTech CRA and CCSE