Commit 389345cf authored Jul 17, 2014 by Andrey Utkin Committed by Greg Kroah-Hartman Jul 17, 2014

drivers/char/dsp56k.c: drop check for negativity of unsigned parameter

[linux-3.16-rc5/drivers/char/dsp56k.c:386]: (style) Checking if unsigned
variable 'arg' is less than zero.

Source code is

            if (arg > 31 || arg < 0)
                return -EINVAL;

But

static long dsp56k_ioctl(struct file *file, unsigned int cmd,
             unsigned long arg)

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=80411


Reported-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: Andrey Utkin <andrey.krieger.utkin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent fe2f17eb

drivers/char/dsp56k.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -383,7 +383,7 @@ static long dsp56k_ioctl(struct file *file, unsigned int cmd,
		return put_user(status, &hf->status);
		}
		case DSP56K_HOST_CMD:
		if (arg > 31 \|\| arg < 0)
		if (arg > 31)
		return -EINVAL;
		mutex_lock(&dsp56k_mutex);
		dsp56k_host_interface.cvr = (u_char)((arg & DSP56K_CVR_HV_MASK) \|

Admin message