Commit 387e2b04 authored May 23, 2006 by Stephen Hemminger Committed by David S. Miller May 23, 2006

[BRIDGE]: need to ref count the LLC sap



Bridge will OOPS on removal if other application has the SAP open.
The bridge SAP might be shared with other usages, so need
to do reference counting on module removal rather than explicit
close/delete.

Since packet might arrive after or during removal, need to clear
the receive function handle, so LLC only hands it to user (if any).

Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 4a063739

net/bridge/br.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -55,7 +55,7 @@ static int __init br_init(void)

		static void __exit br_deinit(void)
		{
		llc_sap_close(br_stp_sap);
		rcu_assign_pointer(br_stp_sap->rcv_func, NULL);

		#ifdef CONFIG_BRIDGE_NETFILTER
		br_netfilter_fini();
		@@ -67,6 +67,7 @@ static void __exit br_deinit(void)

		synchronize_net();

		llc_sap_put(br_stp_sap);
		br_fdb_get_hook = NULL;
		br_fdb_put_hook = NULL;

Admin message