Commit 38712247 authored Jan 26, 2020 by Trond Myklebust Committed by Anna Schumaker Feb 03, 2020

NFSv4: pnfs_roc() must use cred_fscmp() to compare creds

When comparing two 'struct cred' for equality w.r.t. behaviour under
filesystem access, we need to use cred_fscmp().

Fixes: a52458b4 ("NFS/NFSD/SUNRPC: replace generic creds with 'struct cred'.")
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>

parent c0399cf6

fs/nfs/pnfs.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1425,7 +1425,7 @@ retry:
		/* lo ref dropped in pnfs_roc_release() */
		layoutreturn = pnfs_prepare_layoutreturn(lo, &stateid, &iomode);
		/* If the creds don't match, we can't compound the layoutreturn */
		if (!layoutreturn \|\| cred != lo->plh_lc_cred)
		if (!layoutreturn \|\| cred_fscmp(cred, lo->plh_lc_cred) != 0)
		goto out_noroc;

		roc = layoutreturn;