net/mlx5: Remove unused MLX5_*_DOORBELL_LOCK macros (38702cce) · Commits · 戴 / test

MLX5_*_DOORBELL_LOCK macros provided a way to avoid locking for mlx5_write64 on 64-bit platforms where it's not necessary. Currently all calls to mlx5_write64 don't use a spinlock, so the macros became unused. Signed-off-by:

Maxim Mikityanskiy <maximmi@mellanox.com> Reviewed-by:

Eran Ben Elisha <eranbe@mellanox.com> Signed-off-by:

Saeed Mahameed <saeedm@mellanox.com>

include/linux/mlx5/doorbell.h

+0 −8

Original line number	Diff line number	Diff line
		@@ -42,10 +42,6 @@
		* PCI so we won't worry about it.
		*/

		#define MLX5_DECLARE_DOORBELL_LOCK(name)
		#define MLX5_INIT_DOORBELL_LOCK(ptr) do { } while (0)
		#define MLX5_GET_DOORBELL_LOCK(ptr) (NULL)

		static inline void mlx5_write64(__be32 val[2], void __iomem *dest,
		spinlock_t *doorbell_lock)
		{
		@@ -59,10 +55,6 @@ static inline void mlx5_write64(__be32 val[2], void __iomem *dest,
		* MMIO writes.
		*/

		#define MLX5_DECLARE_DOORBELL_LOCK(name) spinlock_t name;
		#define MLX5_INIT_DOORBELL_LOCK(ptr) spin_lock_init(ptr)
		#define MLX5_GET_DOORBELL_LOCK(ptr) (ptr)

		static inline void mlx5_write64(__be32 val[2], void __iomem *dest,
		spinlock_t *doorbell_lock)
		{

Admin message