Commit 385ca38d authored Jul 26, 2020 by Sam Ravnborg

drm/bridge: tc358764: drop drm_connector_(un)register



Drop drm_connector handling that is not needed:

- drm_dev_register() in the display controller driver takes
  care of registering connectors.
  So the call to drm_connector_register() call is not needed in the bridge
  driver.

- Use of drm_connector_unregister() is only required for drivers that
  explicit have called drm_dev_register.

- The reference counting using drm_connector_put() is likewise not needed.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Andrzej Hajda <a.hajda@samsung.com>
Cc: Neil Armstrong <narmstrong@baylibre.com>
Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Cc: Jonas Karlman <jonas@kwiboo.se>
Cc: Jernej Skrabec <jernej.skrabec@siol.net>
Link: https://patchwork.freedesktop.org/patch/msgid/20200726203324.3722593-4-sam@ravnborg.org

parent 9f069c6f

drivers/gpu/drm/bridge/tc358764.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -375,7 +375,6 @@ static int tc358764_attach(struct drm_bridge *bridge,
		drm_connector_attach_encoder(&ctx->connector, bridge->encoder);
		drm_panel_attach(ctx->panel, &ctx->connector);
		ctx->connector.funcs->reset(&ctx->connector);
		drm_connector_register(&ctx->connector);

		return 0;
		}
		@@ -384,10 +383,8 @@ static void tc358764_detach(struct drm_bridge *bridge)
		{
		struct tc358764 *ctx = bridge_to_tc358764(bridge);

		drm_connector_unregister(&ctx->connector);
		drm_panel_detach(ctx->panel);
		ctx->panel = NULL;
		drm_connector_put(&ctx->connector);
		}

		static const struct drm_bridge_funcs tc358764_bridge_funcs = {

Admin message