Commit 385c301c authored Feb 22, 2019 by Bárbara Fernandes Committed by Jonathan Cameron Apr 04, 2019

iio:adc:ad7923: Put macro argument between ()'s



Put macro argument between parenthesis in order to avoid precedence
issues. Solves the following checkpath.pl's messages:

CHECK: Macro argument 'mode' may be better as '(mode)' to avoid
precedence issues
CHECK: Macro argument 'channel' may be better as '(channel)' to
avoid precedence issues
CHECK: Macro argument reuse 'sequence' - possible side-effects?
CHECK: Macro argument 'sequence' may be better as '(sequence)' to
avoid precedence issues
CHECK: Macro argument 'val' may be better as '(val)' to avoid
precedence issues
CHECK: Macro argument 'dec' may be better as '(dec)' to avoid precedence
issues
CHECK: Macro argument 'bits' may be better as '(bits)' to avoid
precedence issues

Signed-off-by: Bárbara Fernandes <barbara.fernandes@usp.br>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

parent c1fc8bb0

drivers/iio/adc/ad7923.c

+5 −5

Original line number	Diff line number	Diff line
		@@ -40,16 +40,16 @@

		#define AD7923_MAX_CHAN 4

		#define AD7923_PM_MODE_WRITE(mode) (mode << 4) /* write mode */
		#define AD7923_CHANNEL_WRITE(channel) (channel << 6) /* write channel */
		#define AD7923_SEQUENCE_WRITE(sequence) (((sequence & 1) << 3) \
		+ ((sequence & 2) << 9))
		#define AD7923_PM_MODE_WRITE(mode) ((mode) << 4) /* write mode */
		#define AD7923_CHANNEL_WRITE(channel) ((channel) << 6) /* write channel */
		#define AD7923_SEQUENCE_WRITE(sequence) ((((sequence) & 1) << 3) \
		+ (((sequence) & 2) << 9))
		/* write sequence fonction */
		/* left shift for CR : bit 11 transmit in first */
		#define AD7923_SHIFT_REGISTER 4

		/* val = value, dec = left shift, bits = number of bits of the mask */
		#define EXTRACT(val, dec, bits) ((val >> dec) & ((1 << bits) - 1))
		#define EXTRACT(val, dec, bits) (((val) >> (dec)) & ((1 << (bits)) - 1))

		struct ad7923_state {
		struct spi_device *spi;

Admin message