vxlan: check return value of gro_cells_init() (384d91c2) · Commits · 戴 / test

gro_cells_init() returns error if memory allocation is failed. But the vxlan module doesn't check the return value of gro_cells_init(). Fixes: ("vxlan: GRO support at tunnel layer")` Signed-off-by:

Taehee Yoo <ap420073@gmail.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

drivers/net/vxlan.c

+9 −2

Original line number	Diff line number	Diff line
		@@ -2779,10 +2779,19 @@ static void vxlan_vs_add_dev(struct vxlan_sock vs, struct vxlan_dev vxlan,
		/* Setup stats when device is created */
		static int vxlan_init(struct net_device *dev)
		{
		struct vxlan_dev *vxlan = netdev_priv(dev);
		int err;

		dev->tstats = netdev_alloc_pcpu_stats(struct pcpu_sw_netstats);
		if (!dev->tstats)
		return -ENOMEM;

		err = gro_cells_init(&vxlan->gro_cells, dev);
		if (err) {
		free_percpu(dev->tstats);
		return err;
		}

		return 0;
		}

		@@ -3043,8 +3052,6 @@ static void vxlan_setup(struct net_device *dev)

		vxlan->dev = dev;

		gro_cells_init(&vxlan->gro_cells, dev);

		for (h = 0; h < FDB_HASH_SIZE; ++h) {
		spin_lock_init(&vxlan->hash_lock[h]);
		INIT_HLIST_HEAD(&vxlan->fdb_head[h]);

Admin message